Update endpoint pattern regex for long TLD by itsjayway · Pull Request #9456 · Azure/azure-cli-extensions

itsjayway · 2025-12-05T19:06:48Z

2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)

Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length

azure-client-tools-bot-prd · 2025-12-05T19:06:52Z

️✔️Azure CLI Extensions Breaking Change Test

️✔️Non Breaking Changes

azure-client-tools-bot-prd · 2025-12-05T19:06:55Z

Hi @itsjayway,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2025-12-05T19:07:00Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2025-12-05T19:07:03Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions · 2025-12-05T19:11:20Z

Hi @itsjayway

⚠️ Release Requirements

Module: footprint

⚠️ Please update VERSION to be 1.0.1b1 in src/footprint/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull request overview

This PR updates the endpoint pattern regex to support longer top-level domains (TLDs) by removing the upper bound restriction, and updates the Azure Footprint Monitoring Management API from version 2020-02-01-preview to 2024-09-16-preview.

Key Changes:

Regex pattern update: Changed TLD length from {2,5} to {2,} to support long TLDs like '.microsoft'
API version bump across all operation files from 2020-02-01-preview to 2024-09-16-preview
Extension version bump from 1.0.0 to 1.0.1

Reviewed changes

Copilot reviewed 34 out of 93 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/footprint/setup.py`	Version bump to 1.0.1
`src/footprint/azext_footprint/manual/version.py`	Version bump to 1.0.1
`src/footprint/HISTORY.rst`	Added changelog entry for version 1.0.1
`src/footprint/azext_footprint/vendored_sdks/footprint/models/_models.py`	Updated endpoint regex pattern from `{2,5}` to `{2,}` for TLD length
Operation files (sync/async)	Updated API version to 2024-09-16-preview across all operation modules
Client configuration files	Updated API version to 2024-09-16-preview
`src/footprint/azext_footprint/tests/latest/recordings/test_footprint.yaml`	Updated test recordings with new API version
`azdev_env/*`	Virtual environment files that should not be committed

necusjz · 2025-12-08T02:40:50Z

/azp run

azure-pipelines · 2025-12-08T02:41:04Z

Azure Pipelines successfully started running 2 pipeline(s).

itsjayway · 2025-12-09T15:45:29Z

Hey @necusjz, thanks for your review. Could you provide guidance in resolving the errors preventing merge?

Release Version Calculation / version-output (pull_request_target) Failing after 11s
Merging is blocked
At least 1 approving review is required by reviewers with write access.
You're not authorized to push to this branch. <----

necusjz · 2025-12-10T00:55:09Z

/azp run

azure-pipelines · 2025-12-10T00:55:22Z

Azure Pipelines successfully started running 2 pipeline(s).

jsntcy · 2025-12-10T05:59:36Z

        'name': {'readonly': True},
        'type': {'readonly': True},
        'endpoint_id': {'readonly': True, 'max_length': 32, 'min_length': 32, 'pattern': r'[a-f0-9]{32}'},
-        'endpoint': {'required': True, 'max_length': 1024, 'min_length': 0, 'pattern': r'^[a-z0-9\*]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,5}(:[0-9]{1,5})?$'},


The change is applied in SDK, but not in CLI extension?

Thanks for your review @jsntcy. This change needs to be done in both places. Our requests go to RPaaS whose specification can be found here https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/footprintmonitoring/resource-manager/Microsoft.FootprintMonitoring/preview/2024-09-16-preview/footprintProfiles.json#L1375C11-L1375C87

Is there an additional path that I'm missing?

azclibot · 2025-12-15T00:02:13Z

[Release] Update index.json for extension [ footprint-1.0.1b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=146641489&view=results

* Update endpoint pattern regex for long TLD 2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length * change api-version to 2024-09-16-preview from 2024-09-16-preview * updated test * updates as per PR guidance * remove venv * match version witth setup.py and sort history.rst by latest first * change release description

Update endpoint pattern regex for long TLD

d0e94ec

2,5 was too limiting for evolving customer requirements (i.e. '.microsoft'). removing the upper bound for TLD length

azure-client-tools-bot-prd bot added this to the January 2026 (2026-01-06) milestone Dec 5, 2025

itsjayway added 2 commits December 5, 2025 14:48

change api-version to 2024-09-16-preview from 2024-09-16-preview

f8dad44

Merge branch 'main' into feature/relax-measurementendpoint-regex

cc88ea6

itsjayway marked this pull request as ready for review December 5, 2025 19:55

Copilot AI review requested due to automatic review settings December 5, 2025 19:55

Copilot started reviewing on behalf of itsjayway December 5, 2025 19:56 View session

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Dec 5, 2025

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread src/footprint/HISTORY.rst

Comment thread azdev_env/pyvenv.cfg Outdated

itsjayway added 3 commits December 5, 2025 15:56

updated test

e00232c

updates as per PR guidance

b77b626

remove venv

e3af87f

yonzhan requested review from jsntcy and necusjz December 6, 2025 00:28

yonzhan assigned necusjz Dec 6, 2025

yonzhan requested a review from kairu-ms December 6, 2025 00:28

necusjz reviewed Dec 8, 2025

View reviewed changes

Comment thread src/footprint/HISTORY.rst Outdated

necusjz reviewed Dec 8, 2025

View reviewed changes

Comment thread src/footprint/setup.py

match version witth setup.py and sort history.rst by latest first

f7d891d

change release description

6ed3d3b

itsjayway force-pushed the feature/relax-measurementendpoint-regex branch from 7ad232b to 6ed3d3b Compare December 9, 2025 15:52

necusjz removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Dec 10, 2025

necusjz added the skip-cal-version label Dec 10, 2025

jsntcy reviewed Dec 10, 2025

View reviewed changes

necusjz approved these changes Dec 14, 2025

View reviewed changes

necusjz merged commit 18bf50c into Azure:main Dec 14, 2025
35 of 36 checks passed

Conversation

itsjayway commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Dec 5, 2025

Uh oh!

yonzhan commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

github-actions bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Release Requirements

Module: footprint

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

necusjz commented Dec 8, 2025

Uh oh!

azure-pipelines bot commented Dec 8, 2025

Uh oh!

Uh oh!

Uh oh!

itsjayway commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

necusjz commented Dec 10, 2025

Uh oh!

azure-pipelines bot commented Dec 10, 2025

Uh oh!

jsntcy Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

itsjayway Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azclibot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

itsjayway commented Dec 5, 2025 •

edited

Loading

azure-client-tools-bot-prd bot commented Dec 5, 2025 •

edited

Loading

github-actions bot commented Dec 5, 2025 •

edited

Loading

itsjayway commented Dec 9, 2025 •

edited

Loading